ivankelly opened a new pull request #2185: [DLOG] LogReader shouldn't be added to pending if not locking URL: https://github.com/apache/bookkeeper/pull/2185 The pendingReaders set in BKDistributedLogManager exists so that if the manager is closed which the lock is being acquired for a reader, that reader will be closed (even though it hasn't been returned to the client). In the case that the reader is opened without a lock, there is not async action being performed. Previously we were also adding these readers to the pendingReaders, but they were never being removed from the pendingReaders, causing a memory leak. This change avoids adding no-locking readers to pendingReaders.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
