karanmehta93 commented on issue #2182: Add API for Bookie checksum verification writeFlags URL: https://github.com/apache/bookkeeper/pull/2182#issuecomment-544621943 > Why do we have to define more constants, one for each supported digest type? The writer already knows the current digest type. How would server know the digestType if we just have a single enum to represent them all. We would then need bit manipulation logic at other places to decode those bits to determine the type. This is helping consolidate some of it. > Side note: we cannot merge this change until the work on the bookie side is not ready and committed. We can release a bookie with some unused features but once we commit to the public client API the feature must be available on the server side. That is fine, I wanted to put this PR out to get some feedback and also reserve the bits from writeFlags.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
