karanmehta93 edited a comment on issue #2182: Add API for Bookie checksum verification writeFlags URL: https://github.com/apache/bookkeeper/pull/2182#issuecomment-545146586 > On the client API we should only have one WriteFlag CHECKSUM_VERIFICATION, as the LedgerHandle already knows the digest type. I guess that comment is coming based on the fact that the WriteFlag enum is based in `org.apache.bookkeeper.client.api` package. However the server also uses it from the same place. `DEFERRED_SYNC` flag has been implemented the same way. The server needs to know the information of digestType and I don't think that parsing raw integer value outside of this enum is a good idea. That being said, I wouldn't ask the app developer to add the corresponding flag on their own. Rather, it would get added automatically as part of LedgerHandle. Does that seem fine? > Another question: MAC needs a password, how will you handle it? We could say that MAC is not supported. We are sending ledger key as part of the request too, hence we can use it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
