eolivelli commented on issue #2228: Account Apache Thrift and Http Client files in LICENSE files URL: https://github.com/apache/bookkeeper/pull/2228#issuecomment-569426912 With this fix the LICENSE file is good in case of STREAMDISABLED=false https://travis-ci.org/apache/bookkeeper/jobs/630331451?utm_medium=notification&utm_source=github_status We have to make a choice: - validate only with -Dstream (the release script builds binaries with -Dstream) - have separate LICENSE files in case of -Dstream and without -Dstream @sijie what's your take ? I would go for simply validating with -Dstream In the future I would like to get rid of -Dstream but that's another story
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
