eolivelli commented on issue #2214: BP-38 Publish Bookie Service Info on Metadata Service URL: https://github.com/apache/bookkeeper/pull/2214#issuecomment-578163781 > Looks good to me. One comment on using protobuf vs json. > > It would be good to to remove the direct zookeeper access for this, as it involves a bunch of zookeeper accesses to get this information. Previously it was 1 getChildren to get all writable bookies. This changes to 1 + n. If we had a rest endpoint on the bookies, it becomes a lot more cachable. @ivankelly I see this cost, but actually we are adding an indirection between the BookieID and the information about how to reach the bookie. `If we had a rest endpoint on the bookies, it becomes a lot more cachable.` We would end up in storing the HTTP endpoint of the bookie and so we won't be able to move the bookie to another DNS name
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
