eolivelli commented on issue #2260: org.apache.bookkeeper.bookie.TestEntryLog is very flaky (expecially on GitHub Actions machines) URL: https://github.com/apache/bookkeeper/issues/2260#issuecomment-586618246 I think that the problem is that this test is using an "entryLogger" variable that can be created by any of the other '@Test' methods. A good fix would be to re-inizialize that variable, like how it is done in most of the other test methods in that file ``` ** * Test the getEntryLogsSet() method. */ @Test public void testGetEntryLogsSet() throws Exception { // create some entries EntryLogManagerBase entryLogManagerBase = ((EntryLogManagerBase) entryLogger.getEntryLogManager()); assertEquals(Sets.newHashSet(), entryLogger.getEntryLogsSet()); entryLogManagerBase.createNewLog(EntryLogger.UNASSIGNED_LEDGERID); entryLogManagerBase.flushRotatedLogs(); assertEquals(Sets.newHashSet(0L, 1L), entryLogger.getEntryLogsSet()); entryLogManagerBase.createNewLog(EntryLogger.UNASSIGNED_LEDGERID); entryLogManagerBase.flushRotatedLogs(); assertEquals(Sets.newHashSet(0L, 1L, 2L), entryLogger.getEntryLogsSet()); } ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
