aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command URL: https://github.com/apache/bookkeeper/pull/2280#issuecomment-595279073 @eolivelli , I think maybe we had different understand on the `hasArg` flag in `org.apache.commons.cli.Options#addOption`. As I understand, if `hasArg` of an `Option` set to true, it means that an argument is required after this option other than this `Option` is must be specified. I think this means if run command with `-dir`, there must be a argument following it like `-dir /data/bookkeeper/journal`, while without the `-dir` option, command still runs well. I try to run the command without `-dir` opiton like this for one journal directory bookie ``` ./bin/bookkeeper shell readjournal /data1/bookkeeper/journal/current/170ab39159f.txn ``` and it works as expected.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
