eolivelli commented on a change in pull request #2240: fix the problem that the
method InetAddress.getLocalHost().getHostAddress() gets ip as 127.0.0.1
URL: https://github.com/apache/bookkeeper/pull/2240#discussion_r388745813
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/net/NetUtils.java
##########
@@ -85,4 +92,46 @@ public static String
resolveNetworkLocation(DNSToSwitchMapping dnsResolver, Inet
return rNames.get(0);
}
+ public static String getLocalHost() throws UnknownHostException {
+ String ip = InetAddress.getLocalHost().getHostAddress();
+ if (InetAddress.getLocalHost().isLoopbackAddress()) {
+ return getAddress();
+ } else {
+ return ip;
+ }
+
+ }
+
+ private static boolean isboolIp(String ipAddress) {
Review comment:
please call this method **acceptIpAddress** or **isIpAddressValid** or
**canUseIpAddress**
please make it visibility "package" and add unit tests.
from the regexp I see that we won't allow IPv6 addresses
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
