eolivelli commented on a change in pull request #2283: Make bookkeeper script
work on Git Bash on Windows
URL: https://github.com/apache/bookkeeper/pull/2283#discussion_r389579517
##########
File path: bin/bookkeeper
##########
@@ -156,26 +162,27 @@ fi
#Change to BK_HOME to support relative paths
cd "$BK_HOME"
if [ ${COMMAND} == "bookie" ]; then
- exec ${JAVA} ${OPTS} ${JMX_ARGS} org.apache.bookkeeper.server.Main --conf
${BOOKIE_CONF} $@
+ $EXECCMD ${JAVA} ${OPTS} ${JMX_ARGS} org.apache.bookkeeper.server.Main
--conf ${BOOKIE_CONF} $@
elif [ ${COMMAND} == "autorecovery" ]; then
- exec ${JAVA} ${OPTS} ${JMX_ARGS}
org.apache.bookkeeper.replication.AutoRecoveryMain --conf ${BOOKIE_CONF} $@
-elif [ ${COMMAND} == "localbookie" ]; then
+ $EXECCMD ${JAVA} ${OPTS} ${JMX_ARGS}
org.apache.bookkeeper.replication.AutoRecoveryMain --conf ${BOOKIE_CONF} $@
+elif [ "${COMMAND}" == "localbookie" ]; then
NUMBER=$1
shift
- exec ${JAVA} ${OPTS} ${JMX_ARGS} -Dzookeeper.4lw.commands.whitelist='*'
org.apache.bookkeeper.util.LocalBookKeeper ${NUMBER} ${BOOKIE_CONF} $@
+ $EXECCMD ${JAVA} ${OPTS} ${JMX_ARGS} '-Dzookeeper.4lw.commands.whitelist=*'
org.apache.bookkeeper.util.LocalBookKeeper ${NUMBER} ${BOOKIE_CONF} $@
+ ${JAVA} ${OPTS} org.apache.bookkeeper.util.LocalBookKeeper ${NUMBER}
${BOOKIE_CONF} $@
Review comment:
it looks like I have committed some debug code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
