hangc0276 commented on issue #2287: Add Journal PageCache flush interval control when journalSyncData is disabled URL: https://github.com/apache/bookkeeper/pull/2287#issuecomment-600025577 I add a test case, please take a look @jiazhai @eolivelli @sijie @merlimat when an entry add into Journal and after journalPageCacheFlushInterval passed, no new entry added into journal, the last added entry will not be flushed to disk from PageCache. In the test case `BookieJournalPageCacheFlushTest#testAckBeforeUnSyncPageCacheFlush`, I just sleep twice journalPageCacheFlushInterval, and add another entry into journal, then check whether foreWriteRequest add into forceWriteRequestQueue.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
