eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-606821744 You did it well. You assigned correct labels. Usually it is better to not self merge your own issues and let another fellow commiter to merge your patches. But there is no such strict rule it it only about community working. The rules are: each patch must have two supporting committers. If the contributor is a committer you just only need another approval. For big changes or changes to the public API we use to issue a BP (Bookkeeper Proposal) and discuss it before discussing the implementation. It is good to have you on board!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
