rdhabalia commented on a change in pull request #2281: [bookie-ledger-recovery]
Fix bookie recovery stuck even with enough ack-quorum response
URL: https://github.com/apache/bookkeeper/pull/2281#discussion_r403332758
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java
##########
@@ -137,8 +140,15 @@ public synchronized void readEntryComplete(final int rc,
final long ledgerId, fi
}
if (numResponsesPending == 0 && !completed) {
Review comment:
yes makes sense. provided test in
https://github.com/apache/bookkeeper/commit/dcdd1e887ef01f7515053f7eb06f8479de8700ff
is not correct and it should cover the coverage and if that covers the
coverage then we won't need this fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
