eolivelli commented on a change in pull request #2303: QuorumCoverage should
only count unknown nodes
URL: https://github.com/apache/bookkeeper/pull/2303#discussion_r405463513
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/RoundRobinDistributionScheduleTest.java
##########
@@ -74,16 +74,6 @@ public void testCoverageSets() {
}
}
assertEquals("Should be no errors", 0, errors);
-
- RoundRobinDistributionSchedule schedule = new
RoundRobinDistributionSchedule(
- 5, 3, 5);
- DistributionSchedule.QuorumCoverageSet covSet =
schedule.getCoverageSet();
- covSet.addBookie(0, BKException.Code.NoSuchLedgerExistsException);
- covSet.addBookie(1, BKException.Code.NoSuchEntryException);
- covSet.addBookie(2, BKException.Code.NoSuchLedgerExistsException);
- covSet.addBookie(3, BKException.Code.UNINITIALIZED);
- covSet.addBookie(4, BKException.Code.UNINITIALIZED);
- assertFalse(covSet.checkCovered());
Review comment:
why dropping this test ?
can't we move this to *assertTrue*
and maybe add other cases ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
