rdhabalia commented on a change in pull request #2303: QuorumCoverage should
only count unknown nodes
URL: https://github.com/apache/bookkeeper/pull/2303#discussion_r410969659
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java
##########
@@ -140,17 +149,15 @@ public synchronized void readEntryComplete(final int rc,
final long ledgerId, fi
}
if (numResponsesPending == 0 && !completed) {
- int totalExepctedResponse =
lh.getLedgerMetadata().getWriteQuorumSize()
Review comment:
yes, change looks good, we don't need this logic if
`coverageSet.checkCovered()` checks correct quorum response.
However, as I explained in another comment: I think
`coverageSet.checkCovered()` doesn't return true if `E=3, W=2, A=2` and if
client receives ack from one of the bookie.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
