hangc0276 commented on pull request #2349:
URL: https://github.com/apache/bookkeeper/pull/2349#issuecomment-636478817


   > For example, the log file is `c.log`, if apply your patch, it will read 
`18.log`, it's wrong.
   > 
   > ```
   > Long.parseLong("12", 16)  =  18
   > ```
   
   @lamber-ken thanks for your reply. The entry log file name is HexString in 
EntryLoggerAllocator.java 
   ```
   logFileName = Long.toHexString(preallocatedLogId) + suffix;
   ```
   
   For the `c.log`, in my patch, it will parse entry log id 
   ```
   Long.parseLong("c", 16)  =  12
   ```
   
   For the command: `ls -al /tmp/bk-data/current`
   ```
   -rw-r--r--   1 root root 1074482107 Apr 16 16:38 3dd.log
   -rw-r--r--   1 root root 1074958616 Apr 16 16:38 3de.log
   -rw-r--r--   1 root root 1074669756 Apr 16 16:39 3df.log
   -rw-r--r--   1 root root 1074372627 Apr 16 16:39 3e0.log
   -rw-r--r--   1 root root 1076423506 Apr 16 16:58 3e8.log
   -rw-r--r--   1 root root 1075989200 Apr 16 16:58 3e9.log
   -rw-r--r--   1 root root 1077057693 Apr 16 16:59 3ea.log
   -rw-r--r--   1 root root 1075034201 Apr 16 17:00 3eb.log
   -rw-r--r--   1 root root 1073316319 Apr 16 21:23 3ec.log
   -rw-r--r--   1 root root   10316071 Apr 16 21:23 3ed.log
   -rw-r--r--   1 root root 1112640702 Apr 20 18:16 3ee.log
   -rw-r--r--   1 root root 1074654208 Apr 20 18:17 3ef.log
   ```
   
   I am confused why `Compatibility Check Java8 / check` run failed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to