eolivelli commented on a change in pull request #2433: URL: https://github.com/apache/bookkeeper/pull/2433#discussion_r502381884
########## File path: docker/Dockerfile ########## @@ -20,20 +20,20 @@ FROM centos:7 MAINTAINER Apache BookKeeper <[email protected]> -ARG BK_VERSION=4.9.0 +ARG BK_VERSION=4.11.0 Review comment: I am not sure that the bash files on 4.9.2 work with java11 due to removed JVM command line flags. 4.10 should work. Btw we are close to releasing 4.12 so 4.9 is becoming far distant from current versions ########## File path: docker/README.md ########## @@ -13,7 +13,7 @@ Bookkeeper needs [Zookeeper](https://zookeeper.apache.org/) in order to preserve Just like running a BookKeeper cluster in one machine(http://bookkeeper.apache.org/docs/latest/getting-started/run-locally/), you can run a standalone BookKeeper in one docker container, the command is: ``` docker run -it \ - --env JAVA_HOME=/usr/lib/jvm/jre-1.8.0 \ + --env JAVA_HOME=/usr/lib/jvm/jdk-11 \ Review comment: I would like, but in current 4.11 we are using the presence of shell to detect jdk11 and it is not present in the. We should fix that problem, then we can use the jre. Btw I don't know a good way to detect jdk11+ ########## File path: docker/Dockerfile ########## @@ -20,20 +20,20 @@ FROM centos:7 MAINTAINER Apache BookKeeper <[email protected]> -ARG BK_VERSION=4.9.0 +ARG BK_VERSION=4.11.0 Review comment: Also It would be better to use the version in pom files and in current master it should be 4.12.0-SNAPSHOT but if I change it the image cannot be built so currently I can only use this version. We are in the middle of the process of releasing 4 11.1 so probably we will set 4.11.1 here on current master. Another solution would be to pick the binaries from local filesystem if the version is a SNAPSHOT ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
