eolivelli commented on a change in pull request #2435:
URL: https://github.com/apache/bookkeeper/pull/2435#discussion_r504794750
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationClient.java
##########
@@ -447,4 +461,46 @@ public synchronized void
unwatchReadOnlyBookies(RegistrationListener listener) {
return newBookieAddrs;
}
+ private static BookieId stripBookieIdFromPath(String path) {
+ final int slash = path.lastIndexOf('/');
+ if (slash >= 0) {
+ try {
+ return BookieId.parse(path.substring(slash + 1));
+ } catch (IllegalArgumentException e) {
+ log.warn("Cannot decode bookieId from {}", path, e);
+ }
+ }
+ return null;
+ }
+
+ private class BookieServiceInfoCacheInvalidationWatcher implements Watcher
{
+
Review comment:
I see these known cases:
- a bookie with a dynamic network address
- changing configuration (change DNS name....)
- you change configuration and add new endpoints (this will happen in the
future, when for instance @sijie will contribute the pure TLS endpoint)
So basically I think they won't change very ofter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
