eolivelli commented on a change in pull request #2450:
URL: https://github.com/apache/bookkeeper/pull/2450#discussion_r511591882
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/zookeeper/ZooKeeperClient.java
##########
@@ -229,7 +229,7 @@ public ZooKeeperClient build() throws IOException,
KeeperException, InterruptedE
if (null == connectRetryPolicy) {
connectRetryPolicy =
- new
BoundExponentialBackoffRetryPolicy(sessionTimeoutMs, sessionTimeoutMs,
Integer.MAX_VALUE);
+ new BoundExponentialBackoffRetryPolicy(0, 0,
Integer.MAX_VALUE);
Review comment:
can we add a comment explaining this choice ?
this way in the future it will be easier to not fall into a question like
"why are we using an hardcoded 0 value" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
