Ghatage commented on a change in pull request #2453:
URL: https://github.com/apache/bookkeeper/pull/2453#discussion_r512407854
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java
##########
@@ -254,23 +254,14 @@ private static ServerConfiguration
parseCommandLine(String[] args)
printUsage();
throw iae;
}
-
- StringBuilder sb = new StringBuilder();
- String[] ledgerDirNames = conf.getLedgerDirNames();
- for (int i = 0; i < ledgerDirNames.length; i++) {
- if (i != 0) {
- sb.append(',');
- }
- sb.append(ledgerDirNames[i]);
- }
-
String hello = String.format(
- "Hello, I'm your bookie, listening on port %1$s. Metadata service
uri is %2$s."
- + " Journals are in %3$s. Ledgers are stored in %4$s.",
+ "Hello, I'm your bookie, bookieId is %1$s, listening on port %2$s.
Metadata service uri is %3$s."
+ + " Journals are in %4$s. Ledgers are stored in %5$s.",
+ conf.getBookieId() != null ? conf.getBookieId() : "<not-set>",
conf.getBookiePort(),
conf.getMetadataServiceUriUnchecked(),
Arrays.asList(conf.getJournalDirNames()),
- sb);
+ Arrays.asList(conf.getLedgerDirNames()));
Review comment:
Good job on the clean up here. We should have started to use it this way
a long time ago.
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/helpers/CommandHelpers.java
##########
@@ -59,14 +58,14 @@ public static String
getBookieSocketAddrStringRepresentation(BookieId bookidId,
}
realHostname = hostname;
}
- return formatBookieSocketAddress(bookieID, ip,
networkAddress.getPort(), realHostname);
+ return formatBookieSocketAddress(bookidId, ip,
networkAddress.getPort(), realHostname);
Review comment:
nit: typo `bookidId` should be `bookieId`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
