eolivelli commented on a change in pull request #2469:
URL: https://github.com/apache/bookkeeper/pull/2469#discussion_r517139067
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java
##########
@@ -1576,4 +1576,17 @@ private void
bookieConnectAfterCookieDeleteWorker(ServerConfiguration conf, Regi
LOG.info("As expected Bookie fails to come up without a cookie in
metadata store.");
}
}
+
+ @Test
+ public void testInvalidServiceMetadataURI() throws Exception {
+ ServerConfiguration conf =
TestBKConfiguration.newServerConfiguration();
+ conf.setMetadataServiceUri("zk+flat:///ledgers"); // default value in
docker image
Review comment:
a more sensible example is zk+null and not zk+flat
we could also add tests about other silly cases, like:
- single slash
- no slash at all
- empty string
- null string
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
