Ghatage commented on a change in pull request #2491:
URL: https://github.com/apache/bookkeeper/pull/2491#discussion_r526236743
##########
File path:
stream/storage/impl/src/main/java/org/apache/bookkeeper/stream/storage/impl/cluster/ZkClusterMetadataStore.java
##########
@@ -58,7 +58,7 @@
private final String zkClusterAssignmentPath;
private final Map<Consumer<Void>, NodeCacheListener>
assignmentDataConsumers;
- private NodeCache assignmentDataCache;
+ private org.apache.curator.framework.recipes.cache.NodeCache
assignmentDataCache;
Review comment:
Sorry I think I might be missing something. Are there overloaded types
of `NodeCache` in the new version?
Why are we giving the fully qualified class name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
