RaulGracia commented on issue #2497:
URL: https://github.com/apache/bookkeeper/issues/2497#issuecomment-734848462


   I have been testing a change in the last couple of days that seems to have 
fixed the problem: As the problem looks client-related, I have updated the 
Bookkeeper client form `4.9.2` to `4.12.0` in Pravega to execute benchmark 
experiments (Bookies are still `4.9.2`). After doing this change, I have not 
been able to reproduce again the `TooLongFrameException` at the server side in 
the last 2 days (normally, this problem is likely to occur under high enough 
load). That is, while we reach saturation scenarios in both cases, after 
upgrading the Bookkeeper client things come back to normal when the load is 
reduced without inducing Bookies to crash.
   
   While we expected that a client upgrade could solve the issue, @fpj and 
myself have been trying to understand what has been the actual change that made 
things better. After looking into the release notes of Bookkeeper versions, we 
realized that since Bookkeeper `4.10.0`, the Netty version has been upgraded 
from `4.1.31.Final` to `4.1.32.Final`: 
https://github.com/apache/bookkeeper/pull/1934
   
   Looking into the release of Netty `4.1.32.Final`, we see the following: 
https://netty.io/news/2018/11/29/4-1-32-Final.html
   > Fix incorrect sizing of temp byte arrays in (Unsafe)ByteBufUtil
   
   Which is related to this PR: https://github.com/netty/netty/pull/8484.
   
   As the Bookkeeper client is heavily dependent on the classes fixed there, we 
thought that it is likely that the Netty upgrade has been the reason for this 
problem to disappear (or at least, to be much harder to reproduce as I have not 
been yet able to do that). In any case, it looks that newer version of Pravega 
will need to upgrade Bookkeeper to mitigate this problem.
   
   I think that we can close this issue for now, unless I find a reproduction 
of the problem with the newer version of the Bookkeeper client.
   
   Thanks for your feedback! 
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to