eolivelli commented on a change in pull request #1949:
URL: https://github.com/apache/bookkeeper/pull/1949#discussion_r539293336
##########
File path: conf/bk_server.conf
##########
@@ -534,6 +534,12 @@ ledgerDirectories=/tmp/bk-data
# True if the bookie should double check readMetadata prior to gc
# verifyMetadataOnGC=false
+# True if bookie should persist entrylog file metadata and avoid in-memory
object allocation
+gcEntryLogMetadataCacheEnabled=false
+
+# Directory to persist Entrylog metadata if
gcPersistentEntrylogMetadataMapEnabled is true
+# gcEntryLogMetadataCachePath=
Review comment:
we should document the behavior of this configuration parameter
in ServerConfiguration we are using a computed default value....
we should have a consistent and documented behavior
https://github.com/apache/bookkeeper/pull/1949/files#diff-ca6cec8ce70c1bb7a79d3aab8ce752deb12731a33348510c2f9472f5d8ef53eeR464
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
##########
@@ -127,35 +127,41 @@ public GarbageCollectorThread(ServerConfiguration conf,
LedgerManager ledgerMana
Executors.newSingleThreadScheduledExecutor(new
DefaultThreadFactory("GarbageCollectorThread")));
}
+ private EntryLogMetadataMap createEntryLogMetadataMap(boolean
gcPersistentEntrylogMetadataMapEnabled) {
+ final String baseDir =
this.entryLogger.getLedgerDirsManager().getAllLedgerDirs().get(0).toString();
+ try {
+ if (gcPersistentEntrylogMetadataMapEnabled) {
+ return new PersistentEntryLogMetadataMap(baseDir, conf);
+ }
+ } catch (IOException e) {
+ LOG.error("Failed to initialize persistent-metadata-map , clean up
{}", baseDir, e);
Review comment:
@rdhabalia please address this comment from me and from @athanatos
cc @merlimat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
