sursingh commented on a change in pull request #2758:
URL: https://github.com/apache/bookkeeper/pull/2758#discussion_r680145286
##########
File path:
stream/storage/impl/src/main/java/org/apache/bookkeeper/stream/storage/impl/metadata/RootRangeStoreImpl.java
##########
@@ -692,7 +696,10 @@ StatusCode verifyStreamRequest(String nsName, String
streamName) {
return FutureUtils.value(null);
} else {
try {
- return
FutureUtils.value(StreamProperties.parseFrom(streamPropBytes));
+ final StreamProperties p =
StreamProperties.parseFrom(streamPropBytes);
+ logger.info("namespace_id={} stream_id={}
storage_container_id={} stream_name={} ",
+ nsId, p.getStreamId(), p.getStorageContainerId(),
p.getStreamName());
+ return FutureUtils.value(p);
Review comment:
We should do this only when we create/delete/modify streams. Also some
context in the log will be useful. eg "Created Stream" etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
