yuruguo commented on pull request #2803: URL: https://github.com/apache/bookkeeper/pull/2803#issuecomment-926257127
> LGTM but: > > * I do not run BK on windows > * AFAIK majority of the contributors don't use windows so it's easy to sneak `\n` later. You might want to try some checkstyle rule or some other code check to prevent these from happening in the future. > > Just out of the curiosity, are you running BK on windows in production or this is strictly for the development? Thanks for you review. In fact, I don’t deploy it on windows. The reason for making this change is to maintain code compatibility (I found that pulsar can be deployed on windows, and corresponding BK components are also possible, although people rarely use it like this. ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
