Myasuka opened a new pull request #2822: URL: https://github.com/apache/bookkeeper/pull/2822
Descriptions of the changes in this PR: ### Motivation The previous comment of `tableOptions.setCacheIndexAndFilterBlocks(true)` is `Options best suited for HDDs`. If the comment thought that we could cache index&filter blocks when using HDD for better performance, however, this is not correct as this option actually helps on limit the memory usage of index & filter blocks. More internal details could refer to https://github.com/facebook/rocksdb/wiki/Block-Cache#caching-index-filter-and-compression-dictionary-blocks Apart from correcting the comment, this PR also add additional options to help improve performance. ### Changes Correct the comment of caching index & filter block with additional options to improve performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
