Vanlightly commented on pull request #2835: URL: https://github.com/apache/bookkeeper/pull/2835#issuecomment-946504910
> Overall looks like a great addition. Can it benefit from MDC? We already pass MDC in the thread pools, adding tags to MDC and using the tags when reporting metrics should be simple. It's a possibility, though it may incur some extra overhead as those tags need to be readded to the map before executing each runnable/callable. I'll submit the work as I have it already implemented and if there is a general consensus that MDC is the best place to store and retrieve these labels we can explore that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
