merlimat commented on a change in pull request #2847:
URL: https://github.com/apache/bookkeeper/pull/2847#discussion_r735855277
##########
File path: bin/bookkeeper
##########
@@ -148,6 +148,11 @@ LOGGING_OPTS=$(build_logging_opts ${BOOKIE_LOG_CONF}
${BOOKIE_LOG_DIR} ${BOOKIE_
BOOKIE_EXTRA_OPTS="${BOOKIE_EXTRA_OPTS}
-Dorg.bouncycastle.fips.approved_only=true"
OPTS="${OPTS} -cp ${BOOKIE_CLASSPATH} ${BOOKIE_OPTS} ${GC_OPTS} ${NETTY_OPTS}
${LOGGING_OPTS} ${BOOKIE_EXTRA_OPTS}"
+VERSION_AUX=`java -version 2>&1|head -n 1|sed 's/"//g'|awk '{print $3}'|awk -F
'.' '{print $1}'`
Review comment:
This will still be a problem in the BK client (used in Pulsar brokers)
and when bookies are not started with these flags.
My suggestion here would be to either:
1. remove the optimization
2. try the reflection and if it fails go back to non-reflection based path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
