lhotari commented on a change in pull request #2857:
URL: https://github.com/apache/bookkeeper/pull/2857#discussion_r736387409



##########
File path: docker/scripts/entrypoint.sh
##########
@@ -41,11 +41,11 @@ function run_command() {
         chmod -R +x ${BINDIR}
         chmod -R +x ${SCRIPTS_DIR}
         echo "This is root, will use user $BK_USER to run command '$@'"
-        sudo -s -E -u "$BK_USER" /bin/bash "$@"
+        exec sudo -s -E -u "$BK_USER" /bin/bash "$@"
         exit
     else
         echo "Run command '$@'"
-        $@
+        exec $@

Review comment:
       I'd assume that $@ would have to be quoted so that parameters are 
preserved properly.
   ```
   exec "$@"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to