pkumar-singh commented on a change in pull request #2867:
URL: https://github.com/apache/bookkeeper/pull/2867#discussion_r739383676
##########
File path: bookkeeper-dist/server/build.gradle
##########
@@ -31,6 +31,7 @@ releaseArtifacts {
dependencies {
implementation project(':bookkeeper-server')
implementation
project(':bookkeeper-stats-providers:prometheus-metrics-provider')
+ implementation project(':bookkeeper-http:vertx-http-server')
Review comment:
Yes actually. Short answer for the reason is stream:server pulls it as
runTimeOnly `runtimeOnly project(':bookkeeper-http:vertx-http-server')`.
There are two ways to deal with this.
1. in stream:server I could change `runtimeOnly
project(':bookkeeper-http:vertx-http-server')` to `implementation
project(':bookkeeper-http:vertx-http-server')`. That way stream:server would
bring in vertx-http-server as its transitive run time dependency to all the
projects that includes stream:server.
2. Other option is let stream:server pull what only and only stream:server
needs and let bookkeeper-dist pull what it needs separately. That is
`bookkeeper-http:vertx-http-server`. I think second is the better option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
