zymap commented on a change in pull request #2870:
URL: https://github.com/apache/bookkeeper/pull/2870#discussion_r740662468
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
##########
@@ -798,13 +835,20 @@ public void openComplete(int rc, final LedgerHandle lh,
Object ctx) {
@Override
public void openComplete(int newrc, final LedgerHandle
newlh, Object newctx) {
if (newrc != BKException.Code.OK) {
- LOG.error("BK error close ledger: " + lId,
BKException.create(newrc));
- finalLedgerIterCb.processResult(newrc, null,
null);
+ if (skipUnrecoverableLedgers) {
Review comment:
I think we don't need to check `NoSuchEntryException`. We are just
opening a ledger not read data and it looks like there is no way to throw that
exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
