pkumar-singh commented on a change in pull request #2874:
URL: https://github.com/apache/bookkeeper/pull/2874#discussion_r742148391
##########
File path: bookkeeper-server/build.gradle
##########
@@ -99,4 +99,7 @@ test.doFirst {
.resolvedArtifacts.find { it.name == 'junit-foundation' }
jvmArgs("-Djunit.timeout.test=600000", "-Djunit.max.retry=3",
"-Djava.net.preferIPv4Stack=true",
"-Dio.netty.leakDetection.level=paranoid")
+ if (JavaVersion.current() > JavaVersion.VERSION_1_8) {
+ jvmArgs("--add-opens", "java.base/jdk.internal.loader=ALL-UNNAMED")
Review comment:
What problem does this PR solve? Or in other words what this jvmArgs
does and lacking this will result in what problem?
##########
File path: bookkeeper-server/build.gradle
##########
@@ -99,4 +99,7 @@ test.doFirst {
.resolvedArtifacts.find { it.name == 'junit-foundation' }
jvmArgs("-Djunit.timeout.test=600000", "-Djunit.max.retry=3",
"-Djava.net.preferIPv4Stack=true",
"-Dio.netty.leakDetection.level=paranoid")
+ if (JavaVersion.current() > JavaVersion.VERSION_1_8) {
+ jvmArgs("--add-opens", "java.base/jdk.internal.loader=ALL-UNNAMED")
Review comment:
Thanks for this contribution. I have one question though.
What problem does this PR solve? Or in other words what this jvmArgs does
and lacking this will result in what problem?
##########
File path: bookkeeper-server/build.gradle
##########
@@ -99,4 +99,7 @@ test.doFirst {
.resolvedArtifacts.find { it.name == 'junit-foundation' }
jvmArgs("-Djunit.timeout.test=600000", "-Djunit.max.retry=3",
"-Djava.net.preferIPv4Stack=true",
"-Dio.netty.leakDetection.level=paranoid")
+ if (JavaVersion.current() > JavaVersion.VERSION_1_8) {
+ jvmArgs("--add-opens", "java.base/jdk.internal.loader=ALL-UNNAMED")
Review comment:
Another thins to note is. For maven `mvn clean package -B -nsu
-DskipBookKeeperServerTests -Dorg.slf4j.simpleLogger.defaultLogLevel=INFO `
therefore for the gradle we are not running bookkeeper-server test on Java 11
as of now.
##########
File path: bookkeeper-server/build.gradle
##########
@@ -99,4 +99,7 @@ test.doFirst {
.resolvedArtifacts.find { it.name == 'junit-foundation' }
jvmArgs("-Djunit.timeout.test=600000", "-Djunit.max.retry=3",
"-Djava.net.preferIPv4Stack=true",
"-Dio.netty.leakDetection.level=paranoid")
+ if (JavaVersion.current() > JavaVersion.VERSION_1_8) {
+ jvmArgs("--add-opens", "java.base/jdk.internal.loader=ALL-UNNAMED")
Review comment:
Another thins to note is. For maven `mvn clean package -B -nsu
-DskipBookKeeperServerTests -Dorg.slf4j.simpleLogger.defaultLogLevel=INFO ` and
therefore for the gradle we are not running bookkeeper-server test on Java 11
as of now.
##########
File path: bookkeeper-server/build.gradle
##########
@@ -99,4 +99,7 @@ test.doFirst {
.resolvedArtifacts.find { it.name == 'junit-foundation' }
jvmArgs("-Djunit.timeout.test=600000", "-Djunit.max.retry=3",
"-Djava.net.preferIPv4Stack=true",
"-Dio.netty.leakDetection.level=paranoid")
+ if (JavaVersion.current() > JavaVersion.VERSION_1_8) {
+ jvmArgs("--add-opens", "java.base/jdk.internal.loader=ALL-UNNAMED")
Review comment:
Another thins to note is. For maven `mvn clean package -B -nsu
-DskipBookKeeperServerTests -Dorg.slf4j.simpleLogger.defaultLogLevel=INFO ` and
therefore for the gradle we are not running bookkeeper-server test on Java 11
as of now. We run other tests but not bookkeeper-server:tests.
##########
File path: bookkeeper-server/build.gradle
##########
@@ -99,4 +99,7 @@ test.doFirst {
.resolvedArtifacts.find { it.name == 'junit-foundation' }
jvmArgs("-Djunit.timeout.test=600000", "-Djunit.max.retry=3",
"-Djava.net.preferIPv4Stack=true",
"-Dio.netty.leakDetection.level=paranoid")
+ if (JavaVersion.current() > JavaVersion.VERSION_1_8) {
+ jvmArgs("--add-opens", "java.base/jdk.internal.loader=ALL-UNNAMED")
Review comment:
What problem does this PR solve? Or in other words what this jvmArgs
does and lacking this will result in what problem?
##########
File path: bookkeeper-server/build.gradle
##########
@@ -99,4 +99,7 @@ test.doFirst {
.resolvedArtifacts.find { it.name == 'junit-foundation' }
jvmArgs("-Djunit.timeout.test=600000", "-Djunit.max.retry=3",
"-Djava.net.preferIPv4Stack=true",
"-Dio.netty.leakDetection.level=paranoid")
+ if (JavaVersion.current() > JavaVersion.VERSION_1_8) {
+ jvmArgs("--add-opens", "java.base/jdk.internal.loader=ALL-UNNAMED")
Review comment:
Thanks for this contribution. I have one question though.
What problem does this PR solve? Or in other words what this jvmArgs does
and lacking this will result in what problem?
##########
File path: bookkeeper-server/build.gradle
##########
@@ -99,4 +99,7 @@ test.doFirst {
.resolvedArtifacts.find { it.name == 'junit-foundation' }
jvmArgs("-Djunit.timeout.test=600000", "-Djunit.max.retry=3",
"-Djava.net.preferIPv4Stack=true",
"-Dio.netty.leakDetection.level=paranoid")
+ if (JavaVersion.current() > JavaVersion.VERSION_1_8) {
+ jvmArgs("--add-opens", "java.base/jdk.internal.loader=ALL-UNNAMED")
Review comment:
Another thins to note is. For maven `mvn clean package -B -nsu
-DskipBookKeeperServerTests -Dorg.slf4j.simpleLogger.defaultLogLevel=INFO `
therefore for the gradle we are not running bookkeeper-server test on Java 11
as of now.
##########
File path: bookkeeper-server/build.gradle
##########
@@ -99,4 +99,7 @@ test.doFirst {
.resolvedArtifacts.find { it.name == 'junit-foundation' }
jvmArgs("-Djunit.timeout.test=600000", "-Djunit.max.retry=3",
"-Djava.net.preferIPv4Stack=true",
"-Dio.netty.leakDetection.level=paranoid")
+ if (JavaVersion.current() > JavaVersion.VERSION_1_8) {
+ jvmArgs("--add-opens", "java.base/jdk.internal.loader=ALL-UNNAMED")
Review comment:
Another thins to note is. For maven `mvn clean package -B -nsu
-DskipBookKeeperServerTests -Dorg.slf4j.simpleLogger.defaultLogLevel=INFO ` and
therefore for the gradle we are not running bookkeeper-server test on Java 11
as of now.
##########
File path: bookkeeper-server/build.gradle
##########
@@ -99,4 +99,7 @@ test.doFirst {
.resolvedArtifacts.find { it.name == 'junit-foundation' }
jvmArgs("-Djunit.timeout.test=600000", "-Djunit.max.retry=3",
"-Djava.net.preferIPv4Stack=true",
"-Dio.netty.leakDetection.level=paranoid")
+ if (JavaVersion.current() > JavaVersion.VERSION_1_8) {
+ jvmArgs("--add-opens", "java.base/jdk.internal.loader=ALL-UNNAMED")
Review comment:
Another thins to note is. For maven `mvn clean package -B -nsu
-DskipBookKeeperServerTests -Dorg.slf4j.simpleLogger.defaultLogLevel=INFO ` and
therefore for the gradle we are not running bookkeeper-server test on Java 11
as of now. We run other tests but not bookkeeper-server:tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
