aloyszhang commented on pull request #2887: URL: https://github.com/apache/bookkeeper/pull/2887#issuecomment-972577775
@Vanlightly > This seems due to the this.join() as that is the moment when another thread is permitted to enter the method. So synchronized isn't doing the job for us. Yes, the original `synchronized ` does not work due to the join(). > Note that I have done a test of a crashing journal followed by an OS signal and the bookie does terminate before the shutdown was completed, so this is something that does need addressing. Do you mean that there is a common shutdown in progress which invoked by the stop command `bookkeeper-deamon stop bookie`, at the same time, the journal thread crashed due to os failure, and the bookie server will shutdown without waiting for the common shutdown to complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
