Vanlightly commented on a change in pull request #2936:
URL: https://github.com/apache/bookkeeper/pull/2936#discussion_r772209490
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java
##########
@@ -327,6 +328,13 @@ public boolean ledgerExists(long ledgerId) throws
IOException {
return ledgerCache.ledgerExists(ledgerId);
}
+ @Override
+ public boolean entryExists(long ledgerId, long entryId) throws IOException
{
+ //Implementation should be as simple as what's below, but this needs
testing
+ //return ledgerCache.getEntryOffset(ledgerId, entryId) > 0;
+ throw new UnsupportedOperationException("entry exists not supported");
Review comment:
Given the bookie is not working anyway, I think the
UnsupportedOperationException more clearly communicates to the person reading
this code that this methods needs implementing for this ledger storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
