pkumar-singh commented on a change in pull request #2946:
URL: https://github.com/apache/bookkeeper/pull/2946#discussion_r774774479



##########
File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java
##########
@@ -93,9 +93,16 @@ public long getLocation(long ledgerId, long entryId) throws 
IOException {
     public long getLastEntryInLedger(long ledgerId) throws IOException {
         if (deletedLedgers.contains(ledgerId)) {
             // Ledger already deleted
-            return -1;
+            if (log.isDebugEnabled()) {

Review comment:
       If you want to change semantics of this method you may have to change 
where and how this method is being used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to