lordcheng10 commented on pull request #2947:
URL: https://github.com/apache/bookkeeper/pull/2947#issuecomment-1003878597
> I left my last comments then I believe that we are good to go
Thank you so much for your suggestions. Great idea！
According to your suggestions, I made the following changes:
1. Don't catch raw Exception when call method of
metadataDriver.isHealthCheckEnabled().get();
2.Default action in method of disableHealthCheck is throw exception:
default CompletableFuture<Void> disableHealthCheck() throws Exception {
throw new Exception("Not support disableHealthCheck");
}
3.the methods disableHealthCheck and enableHealthCheck in the class
org.apache.bookkeeper.meta.MetadataClientDriver are not used and has been
removed. org.apache.bookkeeper.meta.MetadataBookieDriver#disableHealthCheck()
is called in the class org.apache.bookkeeper
.tools.cli.commands.health.SwitchOfHealthCheckCommand, so it cannot be removed。
@eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
