hangc0276 opened a new pull request #2981:
URL: https://github.com/apache/bookkeeper/pull/2981
### Motivation
When we meet the following conditions:
1. configured region aware placement policy
2. enable disk weight based placement
3. fallback random selection when selecting ensemble bookies, such as:
- not enough regions
- rack number less than 2 in one region
It will throw the following exception, and create ledger failed.
```
12:15:36.459 [bookkeeper-ml-scheduler-OrderedScheduler-1-0] ERROR
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl -
[public/default/persistent/test_v2] Encountered unexpected error when creating
ledger
java.lang.NullPointerException: null
at
org.apache.bookkeeper.client.WeightedRandomSelectionImpl.getNextRandom(WeightedRandomSelectionImpl.java:150)
~[io.streamnative-bookkeeper-server-4.14.3.1.jar:4.14.3.1]
at
org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl.selectRandomInternal(RackawareEnsemblePlacementPolicyImpl.java:748)
~[io.streamnative-bookkeeper-server-4.14.3.1.jar:4.14.3.1]
at
org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl.selectRandom(RackawareEnsemblePlacementPolicyImpl.java:698)
~[io.streamnative-bookkeeper-server-4.14.3.1.jar:4.14.3.1]
at
org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl.newEnsembleInternal(RackawareEnsemblePlacementPolicyImpl.java:409)
~[io.streamnative-bookkeeper-server-4.14.3.1.jar:4.14.3.1]
at
org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl.newEnsemble(RackawareEnsemblePlacementPolicyImpl.java:372)
~[io.streamnative-bookkeeper-server-4.14.3.1.jar:4.14.3.1]
at
org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicy.newEnsemble(RackawareEnsemblePlacementPolicy.java:159)
~[io.streamnative-bookkeeper-server-4.14.3.1.jar:4.14.3.1]
at
org.apache.bookkeeper.client.RegionAwareEnsemblePlacementPolicy.newEnsemble(RegionAwareEnsemblePlacementPolicy.java:303)
~[io.streamnative-bookkeeper-server-4.14.3.1.jar:4.14.3.1]
at
org.apache.bookkeeper.client.BookieWatcherImpl.newEnsemble(BookieWatcherImpl.java:270)
~[io.streamnative-bookkeeper-server-4.14.3.1.jar:4.14.3.1]
at
org.apache.bookkeeper.client.LedgerCreateOp.initiate(LedgerCreateOp.java:161)
~[io.streamnative-bookkeeper-server-4.14.3.1.jar:4.14.3.1]
at
org.apache.bookkeeper.client.BookKeeper.asyncCreateLedger(BookKeeper.java:860)
~[io.streamnative-bookkeeper-server-4.14.3.1.jar:4.14.3.1]
at
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl.asyncCreateLedger(ManagedLedgerImpl.java:3657)
~[io.streamnative-managed-ledger-2.8.1.30.jar:2.8.1.30]
at
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl.initializeBookKeeper(ManagedLedgerImpl.java:460)
~[io.streamnative-managed-ledger-2.8.1.30.jar:2.8.1.30]
at
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl.access$400(ManagedLedgerImpl.java:141)
~[io.streamnative-managed-ledger-2.8.1.30.jar:2.8.1.30]
at
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl$1.operationComplete(ManagedLedgerImpl.java:396)
~[io.streamnative-managed-ledger-2.8.1.30.jar:2.8.1.30]
at
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl$1.operationComplete(ManagedLedgerImpl.java:328)
~[io.streamnative-managed-ledger-2.8.1.30.jar:2.8.1.30]
at
org.apache.bookkeeper.mledger.impl.MetaStoreImpl.lambda$getManagedLedgerInfo$2(MetaStoreImpl.java:97)
~[io.streamnative-managed-ledger-2.8.1.30.jar:2.8.1.30]
at
java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:714)
[?:?]
at
java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:478)
[?:?]
at
org.apache.bookkeeper.common.util.OrderedExecutor$TimedRunnable.run(OrderedExecutor.java:203)
[io.streamnative-bookkeeper-common-4.14.3.1.jar:4.14.3.1]
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
[?:?]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
[?:?]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
[?:?]
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
[io.netty-netty-common-4.1.72.Final.jar:4.1.72.Final]
at java.lang.Thread.run(Thread.java:834) [?:?]
```
The root cause of this case it that in `selectRandomInternal`, the
`wRselection` haven't ever update any bookie map and the filed `randomMax` and
`cummulativeMap` doesn't initialized.
### Modification
1. update the `wRSelection`'s map on `selectRandomInternal` method whenever
the `wRSelection` have ever set or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
