lordcheng10 commented on a change in pull request #2947:
URL: https://github.com/apache/bookkeeper/pull/2947#discussion_r783772215



##########
File path: 
bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/SafeRunnable.java
##########
@@ -39,7 +40,7 @@ default void run() {
         }
     }
 
-    void safeRun();
+    void safeRun() throws ExecutionException, InterruptedException;

Review comment:
       like this?
           boolean isEnable = false;
           try {
               isEnable = metadataDriver.isHealthCheckEnabled().get();
           } catch (InterruptedException e) {
               LOG.error("isHealthCheckEnabled throw InterruptedException", e);
           } catch (ExecutionException e) {
               LOG.error("isHealthCheckEnabled throw ExecutionException", e);
           }
           if (!isEnable) {
               LOG.info("Health checks is currently disabled!");
               return;
           }
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to