StevenLuMT commented on a change in pull request #2999:
URL: https://github.com/apache/bookkeeper/pull/2999#discussion_r790369411
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java
##########
@@ -395,14 +395,15 @@ public void readComplete(int rc, LedgerHandle lh,
byte[] data = entry.getEntry();
final long dataLength = data.length;
numEntriesRead.inc();
- numBytesRead.registerSuccessfulValue(dataLength);
ByteBufList toSend = lh.getDigestManager()
.computeDigestAndPackageForSending(entryId,
lh.getLastAddConfirmed(), entry.getLength(),
Unpooled.wrappedBuffer(data, 0, data.length));
+ int readBytes = toSend.readableBytes();
Review comment:
> why did you modify this?
> `numBytesRead` tracks the data that have been read
yes, this numBytesRead equal to readableBytes, I rollback this, thanks
@nicoloboschi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
