hangc0276 commented on a change in pull request #3046:
URL: https://github.com/apache/bookkeeper/pull/3046#discussion_r806349043



##########
File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
##########
@@ -618,6 +618,8 @@ static void writePaddingBytes(JournalChannel jc, ByteBuf 
paddingBuffer, int jour
     final File journalDirectory;
     final ServerConfiguration conf;
     final ForceWriteThread forceWriteThread;
+
+    private FileChannelProvider fileChannelProvider;

Review comment:
       We have set the fileChannelProvider twice in try-catch, so it can't be 
final




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to