lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r808882801
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##########
@@ -376,7 +380,16 @@ private boolean remove(long key1, long key2, long value1,
long value2, int keyHa
}
} finally {
- unlockWrite(stamp);
+ if (size < resizeThresholdBelow) {
Review comment:
> Why are we comparing here 'size' and we are using 'usedBuckets' while
comparing for the other threshold?
When shrinking, size is used because size is the size actually occupied by
the map, so as to determine whether the current wasted memory ratio is
particularly large. If there is too much, then we need to reclaim some memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
