eolivelli commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r809730137
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##########
@@ -75,26 +133,21 @@
boolean test(long key1, long key2, long value1, long value2);
}
- public ConcurrentLongLongPairHashMap() {
- this(DefaultExpectedItems);
- }
-
- public ConcurrentLongLongPairHashMap(int expectedItems) {
- this(expectedItems, DefaultConcurrencyLevel);
- }
-
- public ConcurrentLongLongPairHashMap(int expectedItems, int
concurrencyLevel) {
+ private ConcurrentLongLongPairHashMap(int expectedItems, int
concurrencyLevel,
Review comment:
I would keep and Deprecate all the public constructors.
Otherwise this is a breaking change and we cannot port it to older releases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
