lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810526127
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##########
@@ -220,22 +329,36 @@ public void forEach(BiConsumerLongPair processor) {
}
// A section is a portion of the hash map that is covered by a single
+ @Setter
@SuppressWarnings("serial")
private static final class Section extends StampedLock {
// Keys and values are stored interleaved in the table array
private volatile long[] table;
private volatile int capacity;
private volatile int size;
- private int usedBuckets;
- private int resizeThreshold;
-
- Section(int capacity) {
+ private volatile int usedBuckets;
+ private int resizeThresholdUp;
+ private int resizeThresholdBelow;
+ private volatile float mapFillFactor;
Review comment:
1. Reducing mapFillFactor and mapIdleFactor can allocate more memory
space, reduce the count of rehash, and reduce the time-consuming of put and
remove methods;
2. Adding mapFillFactor and mapIdleFactor can improve the memory space
usage, but the count of rehash will increase, and the time-consuming of put and
remove methods will also increase;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
