lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1053548491
> > > Do we have tests about DeletedValue and the raw contents of the structures? > > > Is it worth to add some little test? > > > We can use PowerMock/Whitebox or pure java reflection to access the internals > > > > > > @eolivelli Do you mean to add some tests to verify that the count of expansions is actually reduced? > > Yes @eolivelli If I want to verify whether the number of expansions is reduced through unit testing, then I need to add a new configuration, such as: isCleanDeletedStatus=true, to control whether the new logic is enabled, so as to compare whether the number of expansions is reduced before and after it is enabled. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
