nicoloboschi commented on a change in pull request #3081:
URL: https://github.com/apache/bookkeeper/pull/3081#discussion_r818892820
##########
File path: site/scripts/javadoc-gen.sh
##########
@@ -7,18 +7,31 @@ function build_javadoc() {
echo "Building the javadoc for version ${version}."
if [ "$version" == "latest" ]; then
- javadoc_gen_dir="${ROOT_DIR}/target/site/apidocs"
+ javadoc_gen_dir="${ROOT_DIR}/build/docs/javadoc"
+ use_gradle=true
cd $ROOT_DIR
else
- javadoc_gen_dir="/tmp/bookkeeper-${version}/target/site/apidocs"
+
rm -rf /tmp/bookkeeper-${version}
- git clone https://github.com/apache/bookkeeper /tmp/bookkeeper-${version}
+ git clone https://github.com/apache/bookkeeper -b "release-${version}"
/tmp/bookkeeper-${version}
cd /tmp/bookkeeper-${version}
- git checkout "release-${version}"
+ if [[ -f "pom.xml" ]]; then
+ use_gradle=false
+ javadoc_gen_dir="/tmp/bookkeeper-${version}/target/site/apidocs"
+ else
+ use_gradle=true
+ javadoc_gen_dir="/tmp/bookkeeper-${version}/build/docs/javadoc"
+ fi
+
fi
javadoc_dest_dir="${ROOT_DIR}/site/docs/${version}/api/javadoc"
rm -rf $javadoc_dest_dir
- mvn clean install javadoc:aggregate -DskipTests
+ if [[ "$use_gradle" == "true" ]]; then
+ ./gradlew generateApiJavadoc
+ else
+ mvn clean install javadoc:aggregate -DskipTests
Review comment:
this script it is intended to also build older bk versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
