lhotari opened a new issue #3105:
URL: https://github.com/apache/bookkeeper/issues/3105


   **FEATURE REQUEST**
   
   [OrderedExecutor uses 
`LinkedBlockingQueue`](https://github.com/apache/bookkeeper/blob/3db4de9da1447e2a5135ac9330d4347b9d220a0d/bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/OrderedExecutor.java#L307-L308)
 (when `enableBusyWait`=false). This is not optimal. 
   
   It looks like @merlimat introduced 
[GrowableArrayBlockingQueue](https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/GrowableArrayBlockingQueue.java)
 with the intention to replace `LinkedBlockingQueue` usage with 
`GrowableArrayBlockingQueue`. However the swtich hasn't happened.
   > In multiple places, (eg: journal, ordered executor, etc..), we are using 
LinkedBlockingQueue instances to pass objects between threads.
   See #153
   
   ### Additional context
   
   The proposal of this issue is to make this change since it would be an 
alternative mitigation for #1791 . The changes in #1792 will most likely need 
to be reverted because the change introduced thread safety issues such as 
#3104. By improving the queue implementation, there would be better performance 
without breaking thread safety.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to