lhotari edited a comment on pull request #3108: URL: https://github.com/apache/bookkeeper/pull/3108#issuecomment-1066553933
> it looks like you are also fixing a bug in GrowableArrayBlockingQueue > > is it possible to cover the fix with a test case please ? Pulsar contains GrowableArrayBlockingQueue too, https://github.com/apache/pulsar/blob/master/pulsar-common/src/main/java/org/apache/pulsar/common/util/collections/GrowableArrayBlockingQueue.java . I picked this fix to the BK version of GrowableArrayBlockingQueue when comparing the classes. The Pulsar version contains also a few other features such as `remove` methods, `forEach` and `toList`. I didn't copy those over. https://github.com/apache/pulsar/pull/1292/files#diff-013ecf9234e6aaa381510e81420c91664149af6d7f16866f1a36b5b3eb71aadcR87 is where the fix was made. It seems that there's not an explicit test for the issue that was fixed there. I guess one way to test for it would be it inspect the internal state? @merlimat Do you have suggestions how to handle the testing for the fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
