eolivelli commented on a change in pull request #3109:
URL: https://github.com/apache/bookkeeper/pull/3109#discussion_r825907041
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
##########
@@ -268,7 +268,11 @@ public String getMetadataServiceUriUnchecked() throws
UncheckedConfigurationExce
* @throws ConfigurationException if the metadata service uri is invalid.
*/
public String getMetadataServiceUri() throws ConfigurationException {
- String serviceUri = getString(METADATA_SERVICE_URI);
+ List servers = getList(METADATA_SERVICE_URI, null);
Review comment:
This is not correct, METADATA_SERVICE_URI is a URI, it is not a list of
servers
for instance it should start with zk://
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/conf/AbstractConfigurationTest.java
##########
@@ -56,6 +56,12 @@ public void setup() {
this.conf.setZkLedgersRootPath("/path/to/ledgers");
}
+ @Test
+ public void testSetGetServiceUri() throws Exception {
+ this.conf.setMetadataServiceUri("zk1:2181,zk2:2181/test");
Review comment:
this is not a valid URI
it should be something like `zk://zk1:2181,zk2:2181/test` or
`zk+null://zk1:2181,zk2:2181/test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
