dlg99 commented on a change in pull request #3110:
URL: https://github.com/apache/bookkeeper/pull/3110#discussion_r833955485
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
##########
@@ -110,6 +110,14 @@
@Override
public void close() {
+ // this request has succeeded before, can't recycle writeSet again
+ if (complete.compareAndSet(false, true)) {
+ rc = BKException.Code.UnexpectedConditionException;
+ writeSet.recycle();
+ }
+ // To be able to close this when complete = true, can't use
compareAndSet.
+ // Because readComplete will make complete = true then close will
not close LedgerEntryImpl
+ complete.set(true);
Review comment:
this is not needed anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
