eolivelli commented on a change in pull request #3137:
URL: https://github.com/apache/bookkeeper/pull/3137#discussion_r835901727



##########
File path: 
bookkeeper-stats-providers/prometheus-metrics-provider/src/main/java/org/apache/bookkeeper/stats/prometheus/PrometheusMetricsProvider.java
##########
@@ -172,6 +172,7 @@ public StatsLogger getStatsLogger(String scope) {
 
     @Override
     public void writeAllMetrics(Writer writer) throws IOException {
+        PrometheusTextFormatUtil.reset();

Review comment:
       This is a sign of something going wrong.
   
   What happens with two concurrent calls to this method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to